Fix tls_ctx memleak in s3 client creation #822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will fix #823 |
bretambrose
reviewed
Aug 20, 2024
src/native/s3_client.c
Outdated
| @@ -521,7 +521,9 @@ JNIEXPORT jlong JNICALL Java_software_amazon_awssdk_crt_s3_S3Client_s3ClientNew( | |||
| env, &proxy_options, jni_proxy_host, jni_proxy_authorization_username, jni_proxy_authorization_password); | |||
|
|
|||
| aws_mem_release(aws_jni_get_allocator(), s3_tcp_keep_alive_options); | |||
|
|
|||
| if (!tls_options) { | |||
There was a problem hiding this comment.
Yes, of course. Last minute change by me which I did not test :)
Will fix it.
Reproduction scenario:
```
try(var tlsc = new TlsContext(); var c = new S3Client(new S3ClientOptions()
.withRegion("eu-west-1")
.withClientBootstrap(ClientBootstrap.getOrCreateStaticDefault())
.withTlsContext(tlsc)
)) {
}
```
--> this code will quickly go OOM without the fix in this commit
|
This fix was merged here, along with test for memory leaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reproduction scenario:
--> this code will quickly go OOM without the fix in this commit
Issue #, if available:
Description of changes:
Make sure
tls_ctxrefcount is decremented by cleaning uptls_options.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.